-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Uint8ArrayList #26
feat: support Uint8ArrayList #26
Conversation
I think we should land alanshaw/it-pushable#30 first so this isn't necessary, otherwise we lose the ability to limit memory usage by inbound/outbound streams in libp2p. |
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 202 232 +30
Branches 23 25 +2
=========================================
+ Hits 202 232 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - if you merge the two suggestions below it becomes a non-breaking change.
Co-authored-by: Alex Potsides <[email protected]>
## [4.1.0](v4.0.1...v4.1.0) (2022-08-03) ### Features * support Uint8ArrayList ([#26](#26)) ([0fc8e5d](0fc8e5d))
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rest
returns unwrapped sourceread
returns Uint8ArrayList which is breaking change, should I subArray into Uint8Array?